siddhantsangwan commented on PR #7976: URL: https://github.com/apache/ozone/pull/7976#issuecomment-2688241334
Update: I pushed a commit to address review comments. It adds logic to move the container to `CLOSED` or `QUASI_CLOSED` depending on the replica's state. The container is moved to `QUASI_CLOSED` only if it's a `RATIS` container (should not be EC - this check is added only to the report handler, do we need to add it to the container manager implementations?). Fixed some minor bugs and added more info to the logging in `AbstractContainerReportHandler`. Added a method to move the container to `QUASI_CLOSED`. I've not done any testing, we need to add tests to validate everything being done in this pull request. Another point to consider - what about empty replicas that are reported while the container is in DELETED state? Earlier we would delete all. Now, should we send a delete command out for the empty ones? We should ideally delete them since we don't want empty ones to get counted in the replication factor checks in Replication Manager. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
