adoroszlai commented on code in PR #8008:
URL: https://github.com/apache/ozone/pull/8008#discussion_r1981737182
##########
hadoop-ozone/ozonefs-shaded/pom.xml:
##########
@@ -102,6 +102,21 @@
<phase>package</phase>
<configuration>
<skip>${maven.shade.skip}</skip>
+ <artifactSet>
+ <excludes>
+ <!-- Leave snappy that includes native methods which cannot
be relocated. -->
+ <exclude>org.xerial.snappy:*</exclude>
Review Comment:
Hadoop added it as dependency:
https://github.com/apache/hadoop/blob/7eb09762f38ac825d8614f6ecc42d041efd087bf/hadoop-client-modules/hadoop-client-api/pom.xml#L70-L76
But I think the idea is to include everything in the fat jar. So I think we
should skip relocation, just like for bouncycastle, instead of completely
excluding it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
