ChenSammi commented on code in PR #8008:
URL: https://github.com/apache/ozone/pull/8008#discussion_r1983370612
##########
hadoop-ozone/ozonefs-shaded/pom.xml:
##########
@@ -120,38 +129,47 @@
<relocation>
<pattern>org</pattern>
<shadedPattern>${shaded.prefix}.org</shadedPattern>
- <includes>
- <include>org.yaml.**.*</include>
- <include>org.sqlite.**.*</include>
- <include>org.tukaani.**.*</include>
- <include>org.bouncycastle.**.*</include>
- <include>org.rocksdb.**.*</include>
- <include>org.apache.commons.cli.**.*</include>
- <include>org.apache.commons.compress.**.*</include>
- <include>org.apache.commons.codec.**.*</include>
- <include>org.apache.commons.beanutils.**.*</include>
- <include>org.apache.commons.collections.**.*</include>
- <include>org.apache.commons.digester.**.*</include>
- <include>org.apache.commons.io.**.*</include>
- <include>org.apache.commons.logging.**.*</include>
- <include>org.apache.commons.validator.**.*</include>
- <include>org.apache.commons.lang3.**.*</include>
- <include>org.sqlite.**.*</include>
- <include>org.apache.thrift.**.*</include>
- </includes>
+ <excludes>
+ <exclude>org.apache.commons.logging.**</exclude>
Review Comment:
```
org.apache.commons.logging.**
org.bouncycastle.**
```
These two are included to shade currently, but excluded in the new change.
Is there any impact if not shaded?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
