hemantk-12 commented on code in PR #7925:
URL: https://github.com/apache/ozone/pull/7925#discussion_r2027309349
##########
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/KeyManagerImpl.java:
##########
@@ -696,6 +696,7 @@ private <V, R> List<Table.KeyValue<String, R>>
getTableEntries(String startKey,
*/
if (startKey != null) {
tableIterator.seek(startKey);
+ } else {
Review Comment:
I made a similar comment on the original patch:
https://github.com/apache/ozone/pull/7200/files#r1762449993.
[RDBStoreByteArrayIterator](https://github.com/apache/ozone/blob/4b9b10f6206ed5c29c0c4957a651de1d24fe86f6/hadoop-hdds/framework/src/main/java/org/apache/hadoop/hdds/utils/db/RDBStoreByteArrayIterator.java#L33)
seeks to first in the constructor. Then why do we need else? Does the reset
require by the caller?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
