adoroszlai commented on PR #7925:
URL: https://github.com/apache/ozone/pull/7925#issuecomment-2775501352
Thanks @swamirishi for adding the tests. IMO they need a whole lot of
cleanup, but in order to get the fix merged, it's OK to create a follow-up task
for that.
@hemantk-12 Please take another look at the actual fix. There was a logic
change since the initial patch. I guess the unit test was useful to prevent
another bug from being introduced. ;)
Old fix:
```diff
@@ -696,7 +696,6 @@ private <V, R> List<Table.KeyValue<String, R>>
getTableEntries(String startKey,
*/
if (startKey != null) {
tableIterator.seek(startKey);
- tableIterator.seekToFirst();
}
int currentCount = 0;
while (tableIterator.hasNext() && currentCount < size) {
```
New fix:
```diff
@@ -696,6 +696,7 @@ private <V, R> List<Table.KeyValue<String, R>>
getTableEntries(String startKey,
*/
if (startKey != null) {
tableIterator.seek(startKey);
+ } else {
tableIterator.seekToFirst();
}
int currentCount = 0;
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
