errose28 commented on code in PR #7474:
URL: https://github.com/apache/ozone/pull/7474#discussion_r2027376353
##########
hadoop-hdds/common/src/main/java/org/apache/hadoop/hdds/client/ReplicationConfig.java:
##########
@@ -112,6 +112,12 @@ static HddsProtos.ReplicationFactor getLegacyFactor(
return ((ReplicatedReplicationConfig) replicationConfig)
.getReplicationFactor();
}
+
+ if (replicationConfig instanceof StandaloneReplicationConfig) {
+ return ((StandaloneReplicationConfig) replicationConfig)
+ .getReplicationFactor();
+ }
+
Review Comment:
I'm pretty sure we can remove this. If there is a specific error when this
is not present then please specify that, but:
- We have always been able to read from block input stream from DNs without
this change.
- Intellij says this new condition is always false, which is correct because
the previous if/return will have executed in this case.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
