errose28 commented on code in PR #7474:
URL: https://github.com/apache/ozone/pull/7474#discussion_r2028993752
##########
hadoop-hdds/container-service/src/main/java/org/apache/hadoop/ozone/container/common/utils/ContainerLogger.java:
##########
@@ -145,6 +148,23 @@ public static void logRecovered(ContainerData
containerData) {
LOG.info(getMessage(containerData));
}
+ /**
+ * Logged when a container is reconciled.
+ *
+ * @param containerData The container that was reconciled on this datanode.
+ * @param oldDataChecksum The old data checksum.
+ */
+ public static void logReconciled(ContainerData containerData, long
oldDataChecksum, DatanodeDetails peer) {
+ if (containerData.getDataChecksum() == oldDataChecksum) {
+ LOG.info(getMessage(containerData, "Container reconciled with peer " +
peer.toString() +
+ ". No change in checksum."));
+ } else {
+ LOG.warn(getMessage(containerData, "Container reconciled with peer " +
peer.toString() +
Review Comment:
It's info if the checksum did not change, warn if it did. It is warning that
there was divergence between peers.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
