peterxcli commented on code in PR #8229:
URL: https://github.com/apache/ozone/pull/8229#discussion_r2029171867
##########
hadoop-ozone/dist/src/main/compose/upgrade/testlib.sh:
##########
@@ -106,7 +106,7 @@ run_test() {
local test_dir="$_upgrade_dir/upgrades/$upgrade_type"
local callback_dir="$test_dir"/callbacks
- local
execution_dir="$test_dir"/execution/"${OZONE_UPGRADE_FROM}-${OZONE_UPGRADE_TO}"
+ local
execution_dir="$test_dir"/execution/"$compose_cluster"/"${OZONE_UPGRADE_FROM}-${OZONE_UPGRADE_TO}"
Review Comment:
How about:
```suggestion
local
execution_dir="$test_dir"/execution/"$compose_cluster-$upgrade_type-${OZONE_UPGRADE_FROM}-${OZONE_UPGRADE_TO}"
```
This would fit better if we have other upgrade type in future.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
