Jimmyweng006 commented on code in PR #8229:
URL: https://github.com/apache/ozone/pull/8229#discussion_r2029711247
##########
hadoop-ozone/dist/src/main/compose/upgrade/testlib.sh:
##########
@@ -106,7 +106,7 @@ run_test() {
local test_dir="$_upgrade_dir/upgrades/$upgrade_type"
local callback_dir="$test_dir"/callbacks
- local
execution_dir="$test_dir"/execution/"${OZONE_UPGRADE_FROM}-${OZONE_UPGRADE_TO}"
+ local
execution_dir="$test_dir"/execution/"$compose_cluster"/"${OZONE_UPGRADE_FROM}-${OZONE_UPGRADE_TO}"
Review Comment:
Hi @peterxcli ,
Thanks for the suggestion. Current change on line 109 **execution_dir** is
based on line 107 **test_dir**, which already include $upgrade_type as folder.
Therefore I think might not need to concatenate $upgrade_type with
$compose_cluster as new folder name.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
