adoroszlai commented on code in PR #8119:
URL: https://github.com/apache/ozone/pull/8119#discussion_r2007022043
##########
hadoop-hdds/common/src/main/resources/ozone-default.xml:
##########
@@ -218,17 +218,6 @@
This volume choosing policy randomly chooses two volumes with remaining
space and then picks the one with lower utilization.
</description>
</property>
- <property>
Review Comment:
Thanks @ChenSammi for the review.
We should not duplicate property between `ozone-default.xml` and annotated
config objects. While looking at `ozone-default.xml` is convenient, searching
(not looking) for property in code is not much more difficult (find in file vs.
find in project). Both kinds of properties are listed in `/config` and `/conf`
endpoints. (I've just found that descriptions are missing, also for both kind
of properties. Filed HDDS-12656.)
Config objects have several benefits, which were described in the design doc
accepted several years ago (HDDS-1466). We also try to further improve them
(see HDDS-12424 as the most recent example).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
