adoroszlai commented on code in PR #8119:
URL: https://github.com/apache/ozone/pull/8119#discussion_r2006958089
##########
hadoop-hdds/container-service/src/main/java/org/apache/hadoop/ozone/container/common/impl/HddsDispatcher.java:
##########
@@ -619,7 +617,7 @@ private boolean isVolumeFull(Container container) {
if (isOpen) {
HddsVolume volume = container.getContainerData().getVolume();
SpaceUsageSource usage = volume.getCurrentUsage();
- long volumeFreeSpaceToSpare =
freeSpaceCalculator.get(usage.getCapacity());
+ long volumeFreeSpaceToSpare =
volume.getFreeSpaceToSpare(usage.getCapacity());
Review Comment:
Yes, I also don't like to pass capacity to volume, so I plan to further
refactor in follow-up. But wanted to avoid bloating this patch.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
