adoroszlai commented on code in PR #8233:
URL: https://github.com/apache/ozone/pull/8233#discussion_r2029844462
##########
hadoop-ozone/integration-test/src/test/java/org/apache/hadoop/ozone/recon/TestReconWithOzoneManagerFSO.java:
##########
@@ -92,11 +89,8 @@ private void writeTestData(String volumeName,
String keyString = UUID.randomUUID().toString();
byte[] data = ContainerTestHelper.getFixedLengthString(
keyString, 100).getBytes(UTF_8);
- OzoneOutputStream keyStream = TestHelper.createKey(
- keyName, ReplicationType.RATIS, ReplicationFactor.ONE,
- 100, store, volumeName, bucketName);
- keyStream.write(data);
- keyStream.close();
+ TestDataUtil.createKey(store.getVolume(volumeName).
+ getBucket(bucketName), keyName, data);
Review Comment:
Please inline `writeTestData`, i.e. move these few lines into `writeKeys`.
Then we can avoid looking up `volume` again.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
