adoroszlai commented on PR #8233: URL: https://github.com/apache/ozone/pull/8233#issuecomment-2781352090
>> I'm wondering are we going to replace the all occurrence of `TestHelper.createKey`? Some tests would assert the later behavior and value change in the attribute of `KeyOutputStream` when the write() is trigger. > > You are right, those tests need `createKey` that returns `OutputStream`. Thanks @chiacyu for updating the patch. Sorry, my previous comment was unclear. I think we should keep using `TestHelper.createKey` for the tests that require `OzoneOutputStream` for further checks. That's because the changes increase duplication, mostly for the volume/bucket lookup, since `TestDataUtil.createKey` expects `OzoneBucket` instead of the name of volume and bucket. So I've reverted 1d2e401cb64fbb7209c24b6bb68cf657fc55db7c + the removal of import from 86231bc476ea2d472b0b4781a95f223cd49c1587. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
