swamirishi commented on code in PR #8243:
URL: https://github.com/apache/ozone/pull/8243#discussion_r2040718040
##########
hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/metadata/BigIntegerCodec.java:
##########
@@ -27,6 +29,7 @@
public final class BigIntegerCodec implements Codec<BigInteger> {
private static final Codec<BigInteger> INSTANCE = new BigIntegerCodec();
+ private static final Comparator<BigInteger> COMPARATOR = (o1, o2) ->
Objects.compare(o1, o2, BigInteger::compareTo);
Review Comment:
IMO any codec for any object it has to encoded in such a way that the
bytewise comparator ordering and the default comparator implementations have to
be aligned. If that is the case then it is wrong. We have a lot of such
instances which are spread across our codebase. I can find more such instances
but I would rather fix the root cause of the issue and encode my objects in a
byte array to ensure rocksdb bytewise ordering and Object comparator is aligned.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
