[
https://issues.apache.org/jira/browse/HDDS-12854?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17945151#comment-17945151
]
Attila Doroszlai commented on HDDS-12854:
-----------------------------------------
These are used and should not be removed:
- declared.hdds.version: used in
hadoop-hdds/common/src/main/resources/hdds-version-info.properties
- declared.ozone.version: used in
hadoop-ozone/common/src/main/resources/ozone-version-info.properties
- ozone.release: this is the national park name of the Ozone release, used in
hadoop-ozone/common/src/main/resources/ozone-version-info.properties
- project.build.outputTimestamp: please see
https://maven.apache.org/guides/mini/guide-reproducible-builds.html
- surefire.failIfNoSpecifiedTests:
https://maven.apache.org/surefire/maven-surefire-plugin/test-mojo.html#failIfNoSpecifiedTests
This one is used, but can be removed, because value is set to the default one:
- failIfNoTests:
https://maven.apache.org/surefire/maven-surefire-plugin/test-mojo.html#failIfNoTests
> Remove unused root pom.xml properties
> -------------------------------------
>
> Key: HDDS-12854
> URL: https://issues.apache.org/jira/browse/HDDS-12854
> Project: Apache Ozone
> Issue Type: Bug
> Components: build
> Affects Versions: 2.1.0
> Reporter: Wei-Chiu Chuang
> Priority: Major
> Attachments: locate_unused_maven_properties.py
>
>
> I used ChatGPT to rewrite a script to identify unused Maven properties. Most
> look legit. We should remove these properties.
> Here's the list:
> {noformat}
> % python3 locate_unused_maven_properties.py ozone ozone/pom.xml
> Parsing root pom.xml for defined properties...
> Found 188 properties in the root pom.xml.
> Searching for module pom.xml files in the project...
> Found 287 module pom.xml files.
> Result:
> The following properties are defined in the root pom.xml but are not used in
> the root (outside of the properties block) or in any module pom.xml:
> - declared.hadoop.version
> - declared.hdds.version
> - declared.ozone.version
> - enforced.java.version
> - enforced.maven.version
> - failIfNoTests
> - maven-surefire-report-plugin.version
> - maven.test.redirectTestOutputToFile
> - native.lib.tmp.dir
> - ozone.release
> - project.build.outputTimestamp
> - project.reporting.outputEncoding
> - sonar.java.binaries
> - surefire.failIfNoSpecifiedTests
> - swagger-annotations-version
> {noformat}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
