priyeshkaratha commented on code in PR #8251:
URL: https://github.com/apache/ozone/pull/8251#discussion_r2048282562


##########
hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/server/SCMClientProtocolServer.java:
##########
@@ -815,33 +902,29 @@ public ScmInfo getScmInfo() {
               .setClusterId(scm.getScmStorageConfig().getClusterID())
               .setScmId(scm.getScmStorageConfig().getScmId())
               
.setPeerRoles(scm.getScmHAManager().getRatisServer().getRatisRoles());
-      return builder.build();
+      ScmInfo info = builder.build();
+      AUDIT.logReadSuccess(buildAuditMessageForSuccess(
+            SCMAction.GET_SCM_INFO, null));
+      return info;
     } catch (Exception ex) {
-      auditSuccess = false;
-      AUDIT.logReadFailure(
-          buildAuditMessageForFailure(SCMAction.GET_SCM_INFO, null, ex)
+      AUDIT.logReadFailure(buildAuditMessageForFailure(

Review Comment:
   Added  for handling unhandled exceptions



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@ozone.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@ozone.apache.org
For additional commands, e-mail: issues-h...@ozone.apache.org

Reply via email to