adoroszlai commented on code in PR #8251: URL: https://github.com/apache/ozone/pull/8251#discussion_r2048230027
########## hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/server/SCMClientProtocolServer.java: ########## @@ -815,33 +902,29 @@ public ScmInfo getScmInfo() { .setClusterId(scm.getScmStorageConfig().getClusterID()) .setScmId(scm.getScmStorageConfig().getScmId()) .setPeerRoles(scm.getScmHAManager().getRatisServer().getRatisRoles()); - return builder.build(); + ScmInfo info = builder.build(); Review Comment: Thanks for spotting this. There are two unused `auditSuccess` declarations: https://github.com/apache/ozone/blob/d6fcef930ea38ff49e8ac79523afa76b3c1b0829/hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/server/SCMClientProtocolServer.java#L898 https://github.com/apache/ozone/blob/d6fcef930ea38ff49e8ac79523afa76b3c1b0829/hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/server/SCMClientProtocolServer.java#L921 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@ozone.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@ozone.apache.org For additional commands, e-mail: issues-h...@ozone.apache.org