aryangupta1998 commented on code in PR #8311:
URL: https://github.com/apache/ozone/pull/8311#discussion_r2054610433
##########
hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/safemode/SCMSafeModeManager.java:
##########
@@ -233,11 +234,32 @@ public void exitSafeMode(EventPublisher eventQueue,
boolean force) {
// set it to true.
setPreCheckComplete(true);
setInSafeMode(false);
+
+ // Manual flag will reset only if we exit from commandline.
+ if (force) {
+ inManualSafeMode.set(false);
+ }
setForceExitSafeMode(force);
// TODO: Remove handler registration as there is no need to listen to
// register events anymore.
+ if (inManualSafeMode.get()) {
+ LOG.info("SCM remains in safe mode as it was manually triggered.");
+ }
+
+ emitSafeModeStatus();
+ }
+
+ /**
+ * Enter safe mode. It does following actions:
+ * <ol>
+ * <li>Set safe mode status to true.
+ * <li>Emit safe mode status.
+ * </ol>
+ */
+ public void enterManualSafeMode(EventPublisher eventQueue) {
Review Comment:
How is eventQueue being used in this function?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@ozone.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@ozone.apache.org
For additional commands, e-mail: issues-h...@ozone.apache.org
