sumitagrawl commented on code in PR #8311:
URL: https://github.com/apache/ozone/pull/8311#discussion_r2055360203


##########
hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/safemode/SCMSafeModeManager.java:
##########
@@ -85,6 +85,7 @@ public class SCMSafeModeManager implements SafeModeManager {
       LoggerFactory.getLogger(SCMSafeModeManager.class);
   private final boolean isSafeModeEnabled;
   private AtomicBoolean inSafeMode = new AtomicBoolean(true);
+  private AtomicBoolean inManualSafeMode = new AtomicBoolean(false);

Review Comment:
   I am not getting purpose to enter safe mode manually ? please specify 
usecase ... Also status in tool GET should represent, else will be difficult to 
identify if in safemode due to restart or manual, and need manual exist safe 
mode.
   Since we are trying to reuse safemode for other porpose, we need define 
impact as observed by user.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@ozone.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@ozone.apache.org
For additional commands, e-mail: issues-h...@ozone.apache.org

Reply via email to