rakeshadr commented on pull request #2151: URL: https://github.com/apache/ozone/pull/2151#issuecomment-822175700
> 1. This patch seems to disable the usage of this feature in any existing cluster, and it can be used only in new cluster. It seems to be a quite huge limitation and I would suggest to mention in at least in the doc: if somebody creates at least one bucket this value can not be changed anymore. Sure, I will update the wiki page and apache docs. "The feature is disabled by default and can be used only in new cluster". > 2. Can you please confirm if this check works well when the metadata is empty? I may be wrong (I didn't test) but I think if I create buckets with existing code (no metadata) and update to this branch and set the layout to 'simple' the cluster couldn't be started. Fix me if I am wrong. Your previous question has the answer - "it can be used only in new cluster". A new cluster will not have any volumes. Simple answer is, during cluster startup the validation logic will check all the existing buckets, if any and then will fail the OM startup if there are any older buckets[simple layout]. > 3. This validation won't work if somebody enables only the prefix-layout without the fs path support. What is the expected behavior in this case? Do we need any validation to avoid such case? Please refer [isFSOptimizedBucket logic](https://github.com/apache/ozone/blob/HDDS-2939/hadoop-ozone/common/src/main/java/org/apache/hadoop/ozone/om/helpers/OzoneFSUtils.java#L226). Here it checks both the properties and FSO requires both to be set(ozone.om.metadata.layout=PREFIX and ozone.om.enable.filesystem.paths=true). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
