elek commented on a change in pull request #2151:
URL: https://github.com/apache/ozone/pull/2151#discussion_r615704267



##########
File path: 
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/OzoneManager.java
##########
@@ -1115,6 +1118,9 @@ public void start() throws IOException {
     getOMMetadataLayout();
 
     metadataManager.start(configuration);
+
+    validatesBucketLayoutMismatches();

Review comment:
       > impact existing OM startup behavior due to this temporary validation 
logic
   
   Thanks the answer @rakeshadr. Can you please help me to understand how can 
moving this line upper would affect OM start behavior?
   
   As far as I understand this check is only applied when 
`OzoneManagerRatisUtils.isBucketFSOptimized` is true. I just asked if this new 
(!) check would be more safe to do before the ratis initialization as 
additional actions may happen before this safety check stops the clusters.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to