peterxcli commented on code in PR #8307:
URL: https://github.com/apache/ozone/pull/8307#discussion_r2078913836
##########
hadoop-hdds/common/src/main/resources/ozone-default.xml:
##########
@@ -1962,6 +1962,15 @@
</description>
</property>
+ <property>
+ <name>ozone.s3g.list.max.keys.limit</name>
Review Comment:
@kerneltime Do you want this config to apply to all "list" related
endpoints? If yes, we should adjust the description and apply the max key logic
to other endpoints in new jira.
##########
hadoop-ozone/dist/src/main/smoketest/s3/maxkeys_validation.robot:
##########
Review Comment:
I think this file should rename to `objectlist.robot`,
`maxkeys_validation.robot` is too specific.
##########
hadoop-ozone/s3gateway/src/test/java/org/apache/hadoop/ozone/s3/endpoint/TestBucketList.java:
##########
@@ -521,6 +521,28 @@ public void testEncodingTypeException() throws IOException
{
assertEquals(S3ErrorTable.INVALID_ARGUMENT.getCode(), e.getCode());
}
+ @Test
Review Comment:
Should add another test case to check if the `max-keys` would be set to the
max-key num defined in config. This can be verified by creating 1000+ key and
list bucket with 1000+ max-key param, then check if the response key num is
1000.
(If we allow the config to be set to lower value then it would be better to
set a low value for it, but it depends on )
##########
hadoop-hdds/common/src/main/resources/ozone-default.xml:
##########
@@ -1962,6 +1962,15 @@
</description>
</property>
+ <property>
+ <name>ozone.s3g.list.max.keys.limit</name>
Review Comment:
Also, should we check that this config must >= 1000?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@ozone.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@ozone.apache.org
For additional commands, e-mail: issues-h...@ozone.apache.org
