Jimmyweng006 commented on code in PR #8307:
URL: https://github.com/apache/ozone/pull/8307#discussion_r2094509055


##########
hadoop-ozone/s3gateway/src/test/java/org/apache/hadoop/ozone/s3/endpoint/TestBucketList.java:
##########
@@ -521,6 +521,28 @@ public void testEncodingTypeException() throws IOException 
{
     assertEquals(S3ErrorTable.INVALID_ARGUMENT.getCode(), e.getCode());
   }
 
+  @Test

Review Comment:
   Thanks for the advice @peterxcli , I update the PR but local CI will take 
some time.
   
   > Should add another test case to check if the max-keys would be set to the 
max-key num defined in config. This can be verified by creating 1000+ key and 
list bucket with 1000+ max-key param, then check if the response key num is 
1000.
   
   The new commit achieves above testing scenario with a lower max key limit, 
please help have a look later. Thank you.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@ozone.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@ozone.apache.org
For additional commands, e-mail: issues-h...@ozone.apache.org

Reply via email to