guihecheng commented on pull request #2158: URL: https://github.com/apache/ozone/pull/2158#issuecomment-823897425
Hi @bshashikant , I'm reviewing this patch myself, here is a summary: # check points: - block/chunk file file operation: covered - container file operation: covered - rocksdb operation: only open, maybe flush, compact, etc - ratis opertation: not covered # tests: - unit-test / integration-test: hdfs has some utils that helps test volume/disk failures, we shall import them to help test e.g. https://github.com/apache/hadoop/blob/6cb90005a7d0651474883ac4e1b6961ef74fe513/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/datanode/DataNodeTestUtils.java#L149-L150 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
