bshashikant commented on pull request #2158: URL: https://github.com/apache/ozone/pull/2158#issuecomment-829234315
> @bshashikant updated with a integration test. > IMHO, #handleNodeLogFailure already handles ratis volume failure by closing pipelines, the failure is detected by ratis itself, and it is not a HddsVolume, so we don't touch it. > cc @ChenSammi Thanks @guihecheng . I think, closing the pipeline on a bad raft log disk will not go through as it needs to take a final snapshot and then remove the pipeline dir. What we also, need to ensure is , mark these disks are bad and remove it from ratis storage dir list, so that no new pipeline creation can happen on these disks. I am not to sure if ratis alredy handles it, but would be good to have a test so that, no new pipeline allocation happens using the bad disks. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
