adoroszlai commented on code in PR #8559:
URL: https://github.com/apache/ozone/pull/8559#discussion_r2126480510
##########
hadoop-hdds/interface-admin/src/main/proto/ScmAdminProtocol.proto:
##########
@@ -209,6 +221,72 @@ message ContainerRequestProto {
optional string traceID = 5;
}
+message ECContainerRequestProto {
+ required ECReplicationConfig ecReplicationConfig = 1;
+ required string owner = 2;
+ optional string traceID = 3;
+}
+
+message ECContainerResponseProto {
+ enum Error {
+ success = 1;
+ errorContainerAlreadyExists = 2;
+ errorContainerMissing = 3;
+ scmNotLeader = 4;
+ }
+ required Error errorCode = 1;
+ required ContainerWithPipeline containerWithPipeline = 2;
+ optional string errorMessage = 3;
+}
+
+message GetEcContainerRequestProto {
+ required int64 containerID = 1;
+ optional string traceID = 2;
+
+}
+
+message GetEcContainerResponseProto {
+ required ContainerInfoProto containerInfo = 1;
+}
+
+message GetEcContainerWithPipelineRequestProto {
+ required int64 containerID = 1;
+ optional string traceID = 2;
+
+}
+
+message GetEcContainerWithPipelineResponseProto {
+ required ContainerWithPipeline containerWithPipeline = 1;
+}
+
+message GetEcContainerReplicasRequestProto {
+ required int64 containerID = 1;
+ optional string traceID = 2;
+}
+
+message GetEcContainerReplicasResponseProto {
+ repeated SCMContainerReplicaProto containerReplica = 1;
+}
+
+message GetEcContainerWithPipelineBatchRequestProto {
+ repeated int64 containerIDs = 1;
+ optional string traceID = 2;
+}
+
+message GetExistEcContainerWithPipelinesInBatchResponseProto {
+ repeated int64 containerIDs = 1;
+ optional string traceID = 2;
+}
+
+message GetExistEcContainerWithPipelinesInBatchRequestProto {
+ repeated int64 containerIDs = 1;
+ optional string traceID = 2;
+}
+
+message GetEcContainerWithPipelineBatchResponseProto {
+ repeated ContainerWithPipeline containerWithPipelines = 1;
+}
+
Review Comment:
We can change factor to `optional`, but should still set some value (in case
the receiver is old version, assuming `required`). It can be any valid value,
as long as it is ignored for EC.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
