sreejasahithi commented on code in PR #8559:
URL: https://github.com/apache/ozone/pull/8559#discussion_r2127050120
##########
hadoop-ozone/cli-admin/src/main/java/org/apache/hadoop/hdds/scm/cli/ContainerOperationClient.java:
##########
@@ -221,6 +221,33 @@ public ContainerWithPipeline
createContainer(HddsProtos.ReplicationType type,
}
}
+ @Override
+ public ContainerWithPipeline createContainer(ReplicationConfig
replicationConfig,
+ String owner) throws
IOException {
+ XceiverClientSpi client = null;
+ XceiverClientManager clientManager = getXceiverClientManager();
+ try {
+ if (replicationConfig == null) {
+ replicationConfig =
ReplicationConfig.fromProtoTypeAndFactor(replicationType, replicationFactor);
+ }
Review Comment:
Please correct me if I am wrong , when the user does not provide replication
type and factor/EC config , then the command should create container with
replication type as STANDALONE and with factor as ONE. So using
Objects.requireNonNull will not help us in doing this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
