adoroszlai opened a new pull request, #8619: URL: https://github.com/apache/ozone/pull/8619
## What changes were proposed in this pull request? Simplify key name validation for OM requests. HDDS-10133 reduced some duplication around validation (`ozone.om.keyname.character.check.enabled` lookup), but: - introduced a short-lived helper object (`ValidateKeyArgs`) and a builder for it - kept duplication related to `FS_FILE_COPYING_TEMP_SUFFIX` We can get rid of leftover duplication and improve performance at the same time: 1. move the property to `OmConfig`, which both reduces duplicated lookup logic and stores the value in a member variable for faster access 2. remove `ValidateKeyArgs`, call each utility method directly 3. notice that `FS_FILE_COPYING_TEMP_SUFFIX` (`"._COPYING_"`) is "valid", so we don't need to remove it before checking keyname for validity https://issues.apache.org/jira/browse/HDDS-13262 ## How was this patch tested? Updated unit test to verify (3). CI: https://github.com/adoroszlai/ozone/actions/runs/15634166481 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
