adoroszlai commented on code in PR #8619:
URL: https://github.com/apache/ozone/pull/8619#discussion_r2151317456
##########
hadoop-hdds/common/src/main/resources/ozone-default.xml:
##########
@@ -3611,16 +3611,6 @@
Thresholds for printing slow-operation audit logs.
</description>
</property>
- <property>
- <name>ozone.om.keyname.character.check.enabled</name>
- <tag>OZONE, OM</tag>
- <value>false</value>
- <description>If true, then enable to check if the key name
- contains illegal characters when creating/renaming key.
- For the definition of illegal characters, follow the
- rules in Amazon S3's object key naming guide.
- </description>
- </property>
Review Comment:
Thanks @nandakumar131 for the review.
> Why did we remove this from `ozone-default.xml`? Are we relying on the
generated `default` xml?
Yes, by moving to `OmConfig` as a `@Config` annotated property, now it is
part of the generated XML, so it should not be in the "manual" XML. I moved it
because of item (1) in the PR description ("reduces duplicated lookup logic and
stores the value in a member variable for faster access").
> we should refactor the code and just stick with one approach
- I started doing that for OM (HDDS-12298), one property (or a group of
properties) at a time, as needed.
- Any new configs being introduced should be `@Config`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
