errose28 commented on code in PR #8448: URL: https://github.com/apache/ozone/pull/8448#discussion_r2141318511
########## hadoop-hdds/container-service/src/main/java/org/apache/hadoop/ozone/container/common/volume/StorageVolumeCheckerMetrics.java: ########## @@ -0,0 +1,104 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.hadoop.ozone.container.common.volume; + +import java.util.Collection; +import org.apache.hadoop.hdds.annotation.InterfaceAudience; +import org.apache.hadoop.metrics2.MetricsSystem; +import org.apache.hadoop.metrics2.annotation.Metric; +import org.apache.hadoop.metrics2.annotation.Metrics; +import org.apache.hadoop.metrics2.lib.DefaultMetricsSystem; +import org.apache.hadoop.metrics2.lib.MutableCounterLong; + +/** + * This class captures the Storage Volume Checker Metrics. + **/ [email protected] +@Metrics(about = "Storage Volume Checker Metrics", context = "dfs") +public class StorageVolumeCheckerMetrics { + public static final String SOURCE_NAME = StorageVolumeCheckerMetrics.class.getSimpleName(); + + @Metric("number of volume checks") + private MutableCounterLong numVolumeChecks; Review Comment: This would be more useful as a gauge that counts the number of volumes the last iteration scanned, like the metric `numContainersScanned` in the container scanner. We can also separate the counts for background and on-demand scans. ```suggestion @Metric("number of volumes scanned") private MutableCounterLong numVolumesScanned; ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
