swamirishi commented on code in PR #8589:
URL: https://github.com/apache/ozone/pull/8589#discussion_r2145329800
##########
hadoop-hdds/container-service/src/main/java/org/apache/hadoop/ozone/container/metadata/WitnessedContainerDBDefinition.java:
##########
@@ -62,7 +61,7 @@ public String getLocationConfigKey() {
return ScmConfigKeys.OZONE_SCM_DATANODE_ID_DIR;
}
- DBColumnFamilyDefinition<ContainerID, String> getContainerIdsTable() {
+ DBColumnFamilyDefinition<ContainerID, ContainerCreateInfo>
getContainerIdsTable() {
Review Comment:
This constructor can initialize from the map of Definitions. I couldn't
comment on the constructor directly
```suggestion
DBColumnFamilyDefinition<ContainerID, ContainerCreateInfo>
getContainerIdsTable() {
Map<String, DBColumnFamilyDefinition> columnFamilies =
definitions.floorEntry(currentVersion)
super(columnFamilies);
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@ozone.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@ozone.apache.org
For additional commands, e-mail: issues-h...@ozone.apache.org
