sumitagrawl commented on code in PR #8589:
URL: https://github.com/apache/ozone/pull/8589#discussion_r2145426099
##########
hadoop-hdds/container-service/src/main/java/org/apache/hadoop/ozone/container/metadata/WitnessedContainerDBDefinition.java:
##########
@@ -62,7 +61,7 @@ public String getLocationConfigKey() {
return ScmConfigKeys.OZONE_SCM_DATANODE_ID_DIR;
}
- DBColumnFamilyDefinition<ContainerID, String> getContainerIdsTable() {
+ DBColumnFamilyDefinition<ContainerID, ContainerCreateInfo>
getContainerIdsTable() {
Review Comment:
We do not need versioning in definition when creation. Currently its simple
map of current definition its handling through out code.
Code redability gets reduced and may need maintain updating for every
LayoutFeatureVersion gets added and error prone.
Current code is for specific version handling only during upgrade and its
simple to point which one its referring. So considering current case, its not
required and such case is rare.
If this issue is frequent, then there is an issue of design of Table which
can not support backward compatibility. And we should use proto to handle same.
IMO, this change is not required.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
