ChenSammi commented on code in PR #8642:
URL: https://github.com/apache/ozone/pull/8642#discussion_r2151659889
##########
hadoop-hdds/container-service/src/main/java/org/apache/hadoop/ozone/container/common/impl/HddsDispatcher.java:
##########
@@ -577,9 +586,11 @@ public void validateContainerCommand(
/**
* If the container usage reaches the close threshold or the container is
* marked unhealthy we send Close ContainerAction to SCM.
+ *
* @param container current state of container
+ * @param cmdType request command type
*/
- private void sendCloseContainerActionIfNeeded(Container container) {
+ private void sendCloseContainerActionIfNeeded(Container container, Type
cmdType) throws StorageContainerException {
Review Comment:
Can we add new function to handle volume full case, and let this
sendCloseContainerActionIfNeeded handle container related cases, so the code is
more readable
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
