ChenSammi commented on code in PR #8642:
URL: https://github.com/apache/ozone/pull/8642#discussion_r2151696563
##########
hadoop-hdds/container-service/src/main/java/org/apache/hadoop/ozone/container/common/impl/HddsDispatcher.java:
##########
@@ -609,6 +615,17 @@ private void sendCloseContainerActionIfNeeded(Container
container) {
LOG.warn("Triggered immediate heartbeat because of full volume.");
}
}
+ if (isVolumeFull) {
+ HddsVolume volume = containerData.getVolume();
+ LOG.warn("Volume [{}] is full. containerID: {}. Volume usage: [{}].",
volume, containerData.getContainerID(),
+ volume.getCurrentUsage());
+ if (cmdType == Type.WriteChunk || cmdType == Type.PutBlock || cmdType
== Type.PutSmallFile) {
+ // If the container is full, we should not allow any more writes.
+ // This will prevent the client from writing to a full container.
+ throw new StorageContainerException("Container creation failed, due
to volume out of space",
+ DISK_OUT_OF_SPACE);
Review Comment:
When this exception happens, will client retry the write with another
pipeline or client will just fail?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
