errose28 commented on code in PR #8550:
URL: https://github.com/apache/ozone/pull/8550#discussion_r2167107332
##########
hadoop-hdds/container-service/src/main/java/org/apache/hadoop/ozone/container/ozoneimpl/OnDemandContainerDataScanner.java:
##########
@@ -100,8 +100,10 @@ private static boolean shouldScan(Container<?> container) {
LOG) && container.shouldScanData();
}
- public static Optional<Future<?>> scanContainer(Container<?> container) {
+ public static Optional<Future<?>> scanContainer(Container<?> container,
String reason) {
Review Comment:
Good point. There's two options here:
1. Import process should clear the last scan timestamp persisted in the
container file. This is relevant for background scanning of the container as
well.
- Basically after import this is a copy/new container and scans on the
original source container should not count.
- This is probably the better option since it fixes prioritization for the
background scanner too.
2. Reconciliation (recently merged) as added the ability to do an on-demand
scan and bypass the scan gap.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
