ptlrs commented on code in PR #8550:
URL: https://github.com/apache/ozone/pull/8550#discussion_r2166042318
##########
hadoop-hdds/container-service/src/main/java/org/apache/hadoop/ozone/container/ozoneimpl/OnDemandContainerDataScanner.java:
##########
@@ -100,8 +100,10 @@ private static boolean shouldScan(Container<?> container) {
LOG) && container.shouldScanData();
}
- public static Optional<Future<?>> scanContainer(Container<?> container) {
+ public static Optional<Future<?>> scanContainer(Container<?> container,
String reason) {
Review Comment:
The `shouldScan(container)` method skips a scan if the container was
recently scanned.
For an imported container, is it possible that the scan will be skipped
because the container was recently scanned before importing and that timestamp
is what is considered post-import?
https://github.com/apache/ozone/blob/6ff3ad66247e1954f696452b0ac373f5f36a0271/hadoop-hdds/container-service/src/main/java/org/apache/hadoop/ozone/container/keyvalue/KeyValueHandler.java#L1165-L1169
https://github.com/apache/ozone/blob/1433d0c047bc561607721c83eefd1a437d2e62b6/hadoop-hdds/container-service/src/main/java/org/apache/hadoop/ozone/container/common/helpers/ContainerUtils.java#L240-L243
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
