ivandika3 commented on PR #8733: URL: https://github.com/apache/ozone/pull/8733#issuecomment-3038837790
> Regarding the unit test, my initial thought is to add a unit test for RoundRobinStrategy, but I’m not sure if that would be sufficient. Yes, we can add a simple unit test on the `RoundRobinStrategy`, although it should be straightforward. The more important test is to validate that the proxy actual routes to different S3Gs, maybe through using `Spy` by parsing the S3G audit logs. > As for merging with the S3G integration tests, do you mean copying the existing integration test classes and replacing S3GatewayService with MultiS3GatewayService? We incorporate the changes in your fork (https://github.com/hevinhsu/ozone/actions/runs/16043512252). I'm OK with replacing the `S3GatewayService` to `MultiS3GatewayService` as long as the tests are fine. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@ozone.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@ozone.apache.org For additional commands, e-mail: issues-h...@ozone.apache.org
