hevinhsu commented on PR #8733: URL: https://github.com/apache/ozone/pull/8733#issuecomment-3061217876
>Yes, we can add a simple unit test on the RoundRobinStrategy, although it should be straightforward. The more important test is to validate that the proxy actual routes to different S3Gs, maybe through using Spy or parsing the S3G audit logs. @ivandika3 I couldn't find a reliable way to identify which S3G endpoint was actually called. I tried parsing the audit logs, but there was no identifier that could distinguish the specific endpoint. I also explored some HTTP endpoints that might expose this information, but couldn't find anything useful — though it's possible I might have missed something in all of these attempts. If I overlooked anything, please feel free to let me know. So instead, I started a simple HTTP server to verify the routing logic. Please take a look and let me know if this approach seems acceptable for validating the strategy. >I'm OK with replacing the S3GatewayService to MultiS3GatewayService as long as the tests are fine. Since the ProxyServer implementation now uses Jetty's ProxyServlet, which handles HTTP headers properly, I've replaced S3GatewayService with MultiS3GatewayService in the integration tests. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@ozone.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@ozone.apache.org For additional commands, e-mail: issues-h...@ozone.apache.org
