symious commented on pull request #2183: URL: https://github.com/apache/ozone/pull/2183#issuecomment-827252271
I think one point of these unit tests is to test the feature of `BackgroundService.PeriodicTask`, if we create a new PeriodicTask implementation for tests, it seems a little diverged from the goal of these unit tests. In [HDDS-4231](https://issues.apache.org/jira/browse/HDDS-4231), the waiting for async results is removed, I think we can only focus on solving the intermittent exception here, no need to write the original code for tests. Besides, the comment of `BackgroundService.PeriodicTask` is not accurate since HDDS-4231, could you help to update the comment? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
