neils-dev commented on pull request #2183: URL: https://github.com/apache/ozone/pull/2183#issuecomment-831653772
Changes pushed to reflect comments. Thanks **@symious** and **@lokeshj1703** for insights and suggestions on the patch to fix the existing problems with the _BlockDeletionService_ related unit tests. To exercise the existing _PeriodicTask_ implementation with our unit tests, I _**removed**_ the extended task from the _BlockDeletingServiceTestImpl_. Instead a timeout is used (3 sec as was defined previously in the _BlockDeletingServiceTestImpl_), for tests involving the background service _BlockDeletionService_. Here, using the _waitFor()_ test util we poll for the workers to finish. This in line with existing tests in the _TestBockDeletionService_. With this implementation we do **_not_** impact the production _backgroundservice_ or any of its subclasses with added variables both volatile and non volatile that can cause unnecessary processing and contention. Thanks guys. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
