xiaoyuyao commented on a change in pull request #2186: URL: https://github.com/apache/ozone/pull/2186#discussion_r622291740
########## File path: hadoop-hdds/framework/src/main/java/org/apache/hadoop/hdds/security/token/ShortLivedTokenVerifier.java ########## @@ -0,0 +1,135 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * <p> + * http://www.apache.org/licenses/LICENSE-2.0 + * <p> + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.hadoop.hdds.security.token; + +import org.apache.hadoop.hdds.protocol.datanode.proto.ContainerProtos; +import org.apache.hadoop.hdds.protocol.datanode.proto.ContainerProtos.ContainerCommandRequestProto; +import org.apache.hadoop.hdds.security.exception.SCMSecurityException; +import org.apache.hadoop.hdds.security.x509.SecurityConfig; +import org.apache.hadoop.hdds.security.x509.certificate.client.CertificateClient; +import org.apache.hadoop.security.UserGroupInformation; +import org.apache.hadoop.security.token.Token; + +import java.io.ByteArrayInputStream; +import java.io.DataInputStream; +import java.io.IOException; +import java.security.cert.CertificateExpiredException; +import java.security.cert.CertificateNotYetValidException; +import java.security.cert.X509Certificate; +import java.time.Instant; +import java.util.Objects; + +/** + * Verifies short-lived token. + * @param <T> type of short-lived token + */ +public abstract class + ShortLivedTokenVerifier<T extends ShortLivedTokenIdentifier> + implements TokenVerifier { + + private final CertificateClient caClient; + private final SecurityConfig conf; + + protected ShortLivedTokenVerifier(SecurityConfig conf, + CertificateClient caClient) { + this.conf = conf; + this.caClient = caClient; + } + + /** Whether the specific kind of token is required for {@code cmdType}. */ + protected abstract boolean isTokenRequired(ContainerProtos.Type cmdType); + + /** Create new empty token identifier, to be filled from Token. */ + protected abstract T createTokenIdentifier(); + + /** Extract info on "service" being accessed by {@code cmd}. */ + protected abstract Object getService(ContainerCommandRequestProto cmd); + + /** Hook for further verification. */ + protected void verify(T tokenId, ContainerCommandRequestProto cmd) + throws SCMSecurityException { + // NOP + } + + @Override + public void verify(String user, Token<?> token, + ContainerCommandRequestProto cmd) throws SCMSecurityException { + + if (!conf.isBlockTokenEnabled()) { Review comment: This is not block token specific, do we have a generic conf here for scm token? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
