adoroszlai commented on a change in pull request #2186:
URL: https://github.com/apache/ozone/pull/2186#discussion_r624443708
##########
File path:
hadoop-hdds/container-service/src/main/java/org/apache/hadoop/ozone/container/common/impl/HddsDispatcher.java
##########
@@ -109,10 +109,8 @@ public HddsDispatcher(ConfigurationSource config,
ContainerSet contSet,
this.containerCloseThreshold = conf.getFloat(
HddsConfigKeys.HDDS_CONTAINER_CLOSE_THRESHOLD,
HddsConfigKeys.HDDS_CONTAINER_CLOSE_THRESHOLD_DEFAULT);
- this.isBlockTokenEnabled = conf.getBoolean(
- HddsConfigKeys.HDDS_BLOCK_TOKEN_ENABLED,
- HddsConfigKeys.HDDS_BLOCK_TOKEN_ENABLED_DEFAULT);
- this.tokenVerifier = tokenVerifier;
+ this.tokenVerifier = tokenVerifier != null ? tokenVerifier
Review comment:
I think checking for `null` here is more defensive. Also,
`HddsDispatcher` is created by several tests, I wanted to avoid changing those.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
