ChenSammi commented on code in PR #8827:
URL: https://github.com/apache/ozone/pull/8827#discussion_r2259503692
##########
hadoop-hdds/container-service/src/main/java/org/apache/hadoop/ozone/container/common/volume/HddsVolume.java:
##########
@@ -111,6 +112,9 @@ public class HddsVolume extends StorageVolume {
private AtomicInteger volumeTestFailureCount;
private Queue<Boolean> volumeTestResultQueue;
+ private volatile CachedPendingDeletion cachedPendingDeletion = null;
Review Comment:
This data for all data volumes(HDDSVolume), so have it in each HddsVolume
duplicate the function.
Consider move it to ContainerController or ContainerSet.
How much time will it take to iterate a 1 million ContainerSet? If it takes
too much time, it's better to have a timerTask to refresh the data
periodically and asynchronizely.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
