Gargi-jais11 opened a new pull request, #8956: URL: https://github.com/apache/ozone/pull/8956
## What changes were proposed in this pull request? **1. Improve data structures and type safety :** - In DiskBalancerService, use ContainerID instead of Long for container id. - Use `Objects.requireNonNull(..)` instead of `Preconditions.checkNotNull(..)`. - In DiskBalancerService do not throw `RuntimeException` instead throw `IOException`. **2. **Replace the use of Optional for method parameters in DiskBalancer**:** As a general rule, parameters should be explicitly required or nullable, not wrapped in an Optional. For context, see: https://www.reddit.com/r/java/comments/sat1j4/opinions_on_using_optional_as_parameter/ **3. Cleanup of Dead Code:** - Remove the `new Container.importContainerData(Path containerPath)` method since it is never used. - Rename `Container.copyContainerData` to `copyContainerDirectory`. As, it sounds like copy/import the ContainerData class. ## What is the link to the Apache JIRA https://issues.apache.org/jira/browse/HDDS-13586 ## How was this patch tested? Passed Existing Tests. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
