ChenSammi commented on PR #8956: URL: https://github.com/apache/ozone/pull/8956#issuecomment-3200165618
Hi @Gargi-jais11 , there are a few comments looks like missed to be addressed. 1. Use StorageVolume.TMP_DIR_NAME to replace DiskBalancerService.DISK_BALANCER_TMP_DIR 2. - In DiskBalancerService, use ContainerID instead of Long for container id. 3. - In DefaultVolumeChoosingPolicy.chooseVolume(..), getCurrentUsage() is called multiple times so it can return different values. 4. SlidingWindow and TestSlidingWindow, what's the usage of SlidingWindow here? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@ozone.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@ozone.apache.org For additional commands, e-mail: issues-h...@ozone.apache.org
