priyeshkaratha commented on code in PR #8963:
URL: https://github.com/apache/ozone/pull/8963#discussion_r2297472662


##########
hadoop-hdds/framework/src/main/java/org/apache/hadoop/hdds/utils/DBCheckpointServlet.java:
##########
@@ -278,6 +279,16 @@ public void 
processMetadataSnapshotRequest(HttpServletRequest request, HttpServl
   }
 
   protected static Set<String> extractSstFilesToExclude(String[] sstParam) {
+    Set<String> receivedSstFiles = new HashSet<>();
+    if (sstParam != null) {
+      receivedSstFiles.addAll(
+          Arrays.stream(sstParam).filter(s -> 
s.endsWith(ROCKSDB_SST_SUFFIX)).distinct().collect(Collectors.toList()));

Review Comment:
   can you mention the advantage of this change compare to existing method in 
PR description?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to