jojochuang commented on code in PR #8963:
URL: https://github.com/apache/ozone/pull/8963#discussion_r2323569383
##########
hadoop-ozone/recon/src/main/java/org/apache/hadoop/ozone/recon/spi/impl/OzoneManagerServiceProviderImpl.java:
##########
@@ -391,7 +391,7 @@ public String getOzoneManagerSnapshotUrl() throws
IOException {
omLeaderUrl = (policy.isHttpsEnabled() ?
"https://"; + info.getServiceAddress(Type.HTTPS) :
"http://"; + info.getServiceAddress(Type.HTTP)) +
- OZONE_DB_CHECKPOINT_HTTP_ENDPOINT;
+ OZONE_DB_CHECKPOINT_HTTP_ENDPOINT_V2;
Review Comment:
This code is used by Recon and here it is assumed that during upgrade
scenario, Recon is upgraded after OM.
##########
hadoop-hdds/framework/src/main/java/org/apache/hadoop/hdds/utils/DBCheckpointServlet.java:
##########
@@ -278,6 +279,16 @@ public void
processMetadataSnapshotRequest(HttpServletRequest request, HttpServl
}
protected static Set<String> extractSstFilesToExclude(String[] sstParam) {
+ Set<String> receivedSstFiles = new HashSet<>();
+ if (sstParam != null) {
+ receivedSstFiles.addAll(
+ Arrays.stream(sstParam).filter(s ->
s.endsWith(ROCKSDB_SST_SUFFIX)).distinct().collect(Collectors.toList()));
+ logSstFileList(receivedSstFiles, "Received list of {} SST files to be
excluded{}: {}", 5);
+ }
+ return receivedSstFiles;
+ }
+
+ protected static Set<String> extractFilesToExclude(String[] sstParam) {
Set<String> receivedSstFiles = new HashSet<>();
Review Comment:
nit: variables used in this method can be renamed to better represent the
purpose.
okay for now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
