adoroszlai commented on code in PR #8945:
URL: https://github.com/apache/ozone/pull/8945#discussion_r2338870407


##########
hadoop-ozone/recon/src/main/java/org/apache/hadoop/ozone/recon/tasks/NSSummaryTask.java:
##########
@@ -295,7 +302,10 @@ public TaskResult buildTaskResult(boolean success) {
    */
   @VisibleForTesting
   public static void resetRebuildState() {
+    // Only reset to IDLE if currently FAILED - never interrupt a RUNNING 
operation
     REBUILD_STATE.set(RebuildState.IDLE);
+    // If state is RUNNING, leave it alone to prevent race conditions
+    // If state is already IDLE, no change needed

Review Comment:
   Seems like mismatch between comment and code (code does not look at current 
state).



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to