swamirishi commented on code in PR #9132:
URL: https://github.com/apache/ozone/pull/9132#discussion_r2428670411
##########
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/OMDBCheckpointServletInodeBasedXfer.java:
##########
@@ -352,13 +351,6 @@ private static void writeHardlinkFile(OzoneConfiguration
conf, Map<String, Strin
Path p = Paths.get(entry.getKey());
String fileId = entry.getValue();
Path relativePath = metaDirPath.relativize(p);
Review Comment:
Please avoid all sorts of hacky if checks like this
https://github.com/apache/ozone/blob/a8695001fdbc60e5dfad0bb1f9ec1526e06c9db9/hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/OMDBCheckpointServletInodeBasedXfer.java#L443-L446
Instead change the function definition of the writeDBToArchive() to also
capture the destination path where the hardLinkFileMap needs to capture this,
that would be more concrete. It can get really tough to debug later on
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
