smengcl commented on code in PR #8587:
URL: https://github.com/apache/ozone/pull/8587#discussion_r2377469691


##########
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/request/key/OMKeyCommitRequest.java:
##########
@@ -336,10 +332,20 @@ public OMClientResponse 
validateAndUpdateCache(OzoneManager ozoneManager, Execut
         // Otherwise, it causes data loss once those shared blocks are added
         // to deletedTable and processed by KeyDeletingService for deletion.
         filterOutBlocksStillInUse(omKeyInfo, oldVerKeyInfo);
-
+        long totalSize = 0;
+        long totalNamespace = 0;

Review Comment:
   This variable is incremented but not used



##########
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/request/key/OMKeyCommitRequest.java:
##########
@@ -336,10 +332,20 @@ public OMClientResponse 
validateAndUpdateCache(OzoneManager ozoneManager, Execut
         // Otherwise, it causes data loss once those shared blocks are added
         // to deletedTable and processed by KeyDeletingService for deletion.
         filterOutBlocksStillInUse(omKeyInfo, oldVerKeyInfo);
-
+        long totalSize = 0;
+        long totalNamespace = 0;

Review Comment:
   This variable is incremented but not read



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to